Use roles from the embedded-cluster config #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-admin-console-show-the-name-for-the
laverya
commented
Nov 15, 2023
Comment on lines
+3
to
+5
| go 1.21.0 | ||
|
|
||
| toolchain go1.21.3 |
There was a problem hiding this comment.
this appears to be required as part of importing embedded-cluster-operator
There was a problem hiding this comment.
would it make it an easier import if there was a separate module for the kinds/apis as we have for kotskinds and kurlkinds? probably not necessary now, but thinking ahead for when the project inevitably grows
There was a problem hiding this comment.
Might be something to consider certainly
…he-admin-console-show-the-name-for-the
cbodonnell
reviewed
Nov 15, 2023
| if err != nil { | ||
| return nil, fmt.Errorf("failed to list installations: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
are there scenarios where the list returned could be empty?
There was a problem hiding this comment.
There's an installation created with every embedded-cluster install, so ideally no
cbodonnell
previously approved these changes
Nov 15, 2023
…he-admin-console-show-the-name-for-the
cbodonnell
approved these changes
Nov 15, 2023
ricardomaraschini
approved these changes
Nov 16, 2023
laverya
deleted the
laverya/sc-92433/in-the-admin-console-show-the-name-for-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Includes the ability to specify custom node roles that include node labels when joining a node to the cluster.
I think no release notes as this is still in a pre-beta state
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?